Netgate SG-1000 microFirewall

Author Topic: User Manager per User Setting  (Read 1763 times)

0 Members and 1 Guest are viewing this topic.

Offline NOYB

  • Hero Member
  • *****
  • Posts: 1703
  • Karma: +158/-273
    • View Profile
User Manager per User Setting
« on: June 30, 2016, 06:24:50 pm »
 
The page is really busy now.  Think it would help for the sections to be hidden when not being used (custom settings checkbox not selected).
 

Offline jdillard

  • Administrator
  • Sr. Member
  • *****
  • Posts: 534
  • Karma: +124/-1
  • Web Dude
    • View Profile
    • Personal Website
Re: User Manager per User Setting
« Reply #1 on: June 30, 2016, 06:41:42 pm »
I was going to make that change, but it wasn't easy to make it backwards compatible.

I think it would be better if each page's settings just remember it's state, that way the checkmarks can be removed.

Offline NOYB

  • Hero Member
  • *****
  • Posts: 1703
  • Karma: +158/-273
    • View Profile
Re: User Manager per User Setting
« Reply #2 on: June 30, 2016, 06:52:44 pm »
 
Backwards compatibility with what?  It's simply if the "Custom Settings" checkbox is checked display the customization settings sections in the user manager page.  If the checkbox is not checked don't display those sections.
 
Has no impact on how the settings work.
 
For an example see interfaces DHCP Client Configuration Options / Advanced Configuration.  When the box is checked to use the options, then the options settings are displayed.  Otherwise not displayed.
 

Offline NOYB

  • Hero Member
  • *****
  • Posts: 1703
  • Karma: +158/-273
    • View Profile
Re: User Manager per User Setting
« Reply #3 on: June 30, 2016, 07:27:05 pm »
 
Looks like the code already does this.  But there is a script error preventing it from working in IE.
 

Offline NOYB

  • Hero Member
  • *****
  • Posts: 1703
  • Karma: +158/-273
    • View Profile
Re: User Manager per User Setting
« Reply #4 on: June 30, 2016, 07:43:36 pm »

Offline cmb

  • Hero Member
  • *****
  • Posts: 11230
  • Karma: +893/-7
    • View Profile
    • Chris Buechler
Re: User Manager per User Setting
« Reply #5 on: June 30, 2016, 08:11:21 pm »
Merged, thanks. That'll be in the next 2.3.2 snapshot, and available for gitsync on RELENG_2_3 within roughly 15 minutes.

Offline jdillard

  • Administrator
  • Sr. Member
  • *****
  • Posts: 534
  • Karma: +124/-1
  • Web Dude
    • View Profile
    • Personal Website
Re: User Manager per User Setting
« Reply #6 on: July 01, 2016, 10:46:39 am »
Hehe oops I was thinking you were describing 'Associated Panels Show/Hide' in General Setup for some reason.
« Last Edit: July 01, 2016, 02:36:28 pm by jdillard »