Netgate Store

Author Topic: Cannot edit firewall rules  (Read 172 times)

0 Members and 1 Guest are viewing this topic.

Offline Spikon

  • Newbie
  • *
  • Posts: 1
  • Karma: +0/-0
    • View Profile
Cannot edit firewall rules
« on: February 23, 2018, 08:38:15 am »
HI Guys,

After upgrading my pfsense firewall software to 2.3.6-DEVELOPMENT I can now longer edit my firewal rules, as soon as I click to edit any of the rules it comes up with the following error:

Parse error: syntax error, unexpected 'In' (T_STRING) in /usr/local/www/firewall_rules_edit.php on line 1712

I had some errors in the past and I have been advised to remove the following bit in green:

// Gateway selector is populated by JavaScript updateGWselect() function
$section->addInput(new Form_Select(
   'gateway',
   'Gateway',
   '',
   []
))->setHelp('Leave as \'default\' to use the system routing table. Or choose a '.
   'gateway to utilize policy based routing. %sGateway selection is not valid for "IPV4+IPV6" address family.', '
'
);


$group = new Form_Group('In / Out pipe'); - This is line 1712

Any thoughts?


Offline KOM

  • Hero Member
  • *****
  • Posts: 5936
  • Karma: +724/-24
    • View Profile
Re: Cannot edit firewall rules
« Reply #1 on: February 23, 2018, 08:44:02 am »
I would take a backup, blow it away, install fresh then restore your backup.  Something went wrong during the upgrade.  You shouldn't have to be manually editing files which will likely get crushed at the next upgrade.

Offline Steve_B

  • Global Moderator
  • Sr. Member
  • *****
  • Posts: 421
  • Karma: +118/-0
    • View Profile
Re: Cannot edit firewall rules
« Reply #2 on: February 23, 2018, 12:44:33 pm »
This is the current/correct code for that section:

Code: [Select]
// Gateway selector is populated by JavaScript updateGWselect() function
$section->addInput(new Form_Select(
'gateway',
'Gateway',
'',
[]
))->setHelp('Leave as \'default\' to use the system routing table. Or choose a '.
'gateway to utilize policy based routing. %sGateway selection is not valid for "IPV4+IPV6" address family.', array('<br />'));

$group = new Form_Group('In / Out pipe');


I don't know why your system is not picking up the current version (2.3.6.a.20180223.0519) Try option 13 from the command line interface and see if that helps.
« Last Edit: February 23, 2018, 12:55:21 pm by Steve_B »