Netgate SG-1000 microFirewall

Author Topic: How do I close a ticket on redmine?  (Read 103 times)

0 Members and 1 Guest are viewing this topic.

Offline LedPighp

  • Newbie
  • *
  • Posts: 4
  • Karma: +0/-0
    • View Profile
How do I close a ticket on redmine?
« on: March 28, 2018, 10:46:49 pm »
What's the process I should follow to close a ticket that I filed on redmine?

I filed a feature request https://redmine.pfsense.org/issues/8123 to track a feature I was going to push pfSense. I left it unassigned when I submitted it since I wasn't sure what to target for the release and other fields that should have been filled in.

Later I submitted a pull request and that was merged into master. It's now present in the 2.4.3 RC and I've verified that it works.

How can I close the original ticket? I'm not permitted to make edits. Also, what's the preferred workflow you'd like us to follow? I didn't see anything in the Wiki back in November when I looked.

Thanks


Offline heper

  • Hero Member
  • *****
  • Posts: 2729
  • Karma: +259/-12
    • View Profile
Re: How do I close a ticket on redmine?
« Reply #1 on: March 29, 2018, 06:09:43 am »
only netgate staff can close/edit tickets.
ask the one who merged the PR to close the redmine.

steve probably didn't notice the PR-title matched a redmine ticket. (might be best to include the direct link in the comment in the future)
so either you update the redmine ticket & ask for it to be closed by steve (the one who merged it).
Or
you mention @sbeaver-netgate in a new comment on PR #3875 on github



Offline jimp

  • Administrator
  • Hero Member
  • *****
  • Posts: 21749
  • Karma: +1503/-26
    • View Profile
Re: How do I close a ticket on redmine?
« Reply #2 on: March 29, 2018, 07:39:14 am »
I added a note and closed out the ticket for you.

We now require a cross-reference between Redmine issues and PRs for submissions, so we can catch things like this, but this was merged just before we started doing that.
Need help fast? Commercial Support!

Co-Author of pfSense: The Definitive Guide. - Check the Doc Wiki for FAQs.

Do not PM for help!